search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Add support for density compensation #109

Closed chaithyagr closed 4 years ago

chaithyagr commented 4 years ago

I have made a quick pypi release of gpuNUFFT with support for density estimation.

This PR mainly handles all the codes to have density compensation based reconstructions.

Starting the review as it is pretty much complete from my side (except any upcoming issues). This is the final PR before an official release of pysap-mri !!

Adding @Daval-G for testing the codes, please follow the methods and let me know if you face any issues. Adding @zaccharieramzi in meantime for code and doc review.

chaithyagr commented 4 years ago

Rebased to master !

chaithyagr commented 4 years ago

The code is working on my side, and the examples produce relevant results. However I noticed some old warnings: UserWarning: pynufft python package has not been found. If needed use the master release. Till then you cannot use NUFFT on GPU

Since this PR is related to the stable release of gpuNUFFT as a python package, it would be relevant to update related warnings in the code (pynufft is not the only GPU option proposed anymore). Also more formality in the message would be appreciated.

Yes, you are right, this might confuse the users. I will move to having the codes actually add this as an error only if the class is called, this is obsolete at this point.

chaithyagr commented 4 years ago

Will merge once @zaccharieramzi completes the final review...

chaithyagr commented 4 years ago

All changes are in, @zaccharieramzi you can review again at convenience