search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

[SHORT] Fix up codes for FFT class, making it more user friendly and fix grid search #111

Closed chaithyagr closed 3 years ago

chaithyagr commented 3 years ago

This PR Covers:

  1. Option for user to send mask directly
  2. Using axes parameter of np.fft.fftn to do FFT in vectorized way, than using loops
  3. Send n_coils to parameters in grid search
chaithyagr commented 3 years ago

Looks like scipy for some reason gives different result, causing issues when we compare Noncartesian to cartesian in some tests Currently I have added relative tolerance of 1e-3 for it

chaithyagr commented 3 years ago

Also, I had a minute issue in gridsearch scripts which came up while using it, the n_coils term is missing and since it is a single line, I am merging it to this PR

zaccharieramzi commented 3 years ago

LGTM @chaithyagr , I'll let you merge when you think it's time

chaithyagr commented 3 years ago

merging, I see that the code worked on circleci well.