Add oscar scale based proximity

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package

Other

43 stars 18 forks source link

Add oscar scale based proximity #114

Closed chaithyagr closed 3 years ago

chaithyagr commented 3 years ago

Hello,

This PR holds 1) Oscar proximity that works scale based 2) Made string compares with == rather than is which used to cause run errors. 3) Some reformatting of codes.

zaccharieramzi commented 3 years ago

Hi @chaithyagr ,

Can you give me more context on what exactly you did regarding the main point of this PR

Oscar proximity that works scale based ?

I am really not familiar with this so my review may be too shallow. Any pointer would be appreciated.

chaithyagr commented 3 years ago

Ahh okay, my bad. So, currently, the codes only allow for OSCAR regularizer where the prximity is done on every band of wavelet or every coefficient of wavelet or gloablly. (all methods are summarized in a document which I will send off hand)

I have now added scale based proximity. You can ask me off hand for any questions, or we can meet up face to face to speed this process up. For now this PR is not highest priority.