search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Preparing for a release v0.3 #120

Closed chaithyagr closed 3 years ago

chaithyagr commented 3 years ago

This PR holds the release for v0.3. We will have pyNFFT as an optional install clearing the way for easier install for users. The README is appropriately updated. Also, I have added the current maintainers/developers in the README.

The updates in this release include:

1) #118 Refactor and remove unwanted imports in CircleCI 2) #111 Fix FFT class, move to scipy.fft to better handle multi-process. Also fix the grid-search 3) #113 Fix the normalize_frequency_locations code to work well with given KMax 4) #114 Add oscar regularization based on scale

chaithyagr commented 3 years ago

@sfarrens let me know if you have issues in running things on Mac. I will try to see if I can get a CI up for mac (currently I didnt considering that our tests are extensive and take a lot of time)

sfarrens commented 3 years ago

Hi @chaithyagr this branch builds fine on my mac so I think everything should be fine to release.

I made one comment regarding the installation of pyNFFT on macOS. If pyNFFT will work then I suggest you make the proposed change. If not, then I would recommend we simply remove the macOS section until we have a stable solution. Hopefully by the next release.

chaithyagr commented 3 years ago

Currently, the tests are failing due to issues in Modopt. @sfarrens can you please make a release of Modopt so that I can make a release here?

sfarrens commented 3 years ago

@chaithyagr I am waiting for a review of the ModOpt release PR then I will release a new patch.

sfarrens commented 3 years ago

@chaithyagr ModOpt v1.5.1 has been released.