CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

[TASK][Plugin Merge] Merging `pysap-mri-online` to `pysap-mri` #129

Closed chaithyagr closed 2 years ago

chaithyagr commented 2 years ago

This issue tracks the merging of pysap-mri-online plugin developed by @paquiteau at here Steps to be done:

paquiteau commented 2 years ago

I don't plan on adding Non Cartesian Generator for now, It will probably requires some heavy changes in NonCartesianFFT/gpuNUFFT operators (update samples points and density compensation for instance), also, some extra algorithmic thinking (like the one of ColumnFFT) needs to be found to make it worth.

paquiteau commented 2 years ago

The ModOpt Integration of optimizer is tracked here: https://github.com/CEA-COSMIC/ModOpt/issues/194. The pull request associated is here: https://github.com/CEA-COSMIC/ModOpt/pull/195

chaithyagr commented 2 years ago

@paquiteau can we close this?

paquiteau commented 2 years ago

Yes ! All PR have been merged in their corresponding repos.