search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Generators #133

Closed paquiteau closed 2 years ago

paquiteau commented 2 years ago

Splittings things up: This PR add support for Generators of Kspace (iterate over the available acquisition data). These can be use with ColumnFFT Operator to reduce memory footprint and speed up computations.

codecov-commenter commented 2 years ago

Codecov Report

Merging #133 (0d59c50) into master (76ddca8) will increase coverage by 1.38%. The diff coverage is 92.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   81.18%   82.56%   +1.38%     
==========================================
  Files          39       45       +6     
  Lines        1982     2191     +209     
==========================================
+ Hits         1609     1809     +200     
- Misses        373      382       +9
Flag Coverage Δ
unittests 82.56% <92.34%> (+1.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mri/generators/base.py 64.28% <64.28%> (ø)
mri/tests/test_online_fourier.py 97.67% <97.67%> (ø)
mri/generators/__init__.py 100.00% <100.00%> (ø)
mri/generators/cartesian.py 100.00% <100.00%> (ø)
mri/operators/fourier/online.py 100.00% <100.00%> (ø)
mri/tests/test_generators.py 100.00% <100.00%> (ø)
mri/operators/fourier/cartesian.py 91.89% <0.00%> (+5.40%) :arrow_up:
mri/scripts/gridsearch.py 88.00% <0.00%> (+6.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76ddca8...0d59c50. Read the comment docs.

chaithyagr commented 2 years ago

@paquiteau assume I approved the PR after the above 2 requests are tackled.