CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
42 stars 18 forks source link

Adding examples #35

Closed LElgueddari closed 4 years ago

LElgueddari commented 4 years ago

Could we add examples to the MRI plugins this would be much easier to test and integrate the new features developed? Also, exemples could be tested with CircleCI to make sure that they are still running perfectly when we do changes?

chaithyagr commented 4 years ago

Also, exemples could be tested with CircleCI to make sure that they are still running perfectly when we do changes?

How do we plan on doing this? I mean we can have examples run, but what will be the check criteria to ensure it is running right?

chaithyagr commented 4 years ago

Listing out Examples that we could have here, please add / remove on to the list:

{Cartesian / Non Cartesian} x {2D} x {Single Channel, Multichannel} For Multichannel: {Self Calibrating and Calibrationless} Number = 6

{Non Cartesian} x {3D} x {Single Channel, Multichannel} For Multichannel: {Self Calibrating and Calibrationless} Number = 3

{2D/3D} x Dictionary Learning. Number = 2

TOTAL = 11

chaithyagr commented 4 years ago

As a first step, I will get a PR for following examples: 1) 2D Single Channel Cartesian with:

2) 2D Single Channel Non-Cartesian with:

@LElgueddari , do you want to add or modify any?

zaccharieramzi commented 4 years ago

I think one optimisation algorithm should be enough for the purpose of the paper. If we want to showcase the possibilities to gain speed using different algorithms we can just refer to my benchmark.

chaithyagr commented 4 years ago

I think we have satisfied the purpose of this issue. Re-purposing now to ensure we have one example for each type of reconstruction.

chaithyagr commented 4 years ago

I think this can be closed now as we have one example of each kind. Closing.