Unused variables in `sparse_rec_fista`

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package

Other

43 stars 18 forks source link

Unused variables in `sparse_rec_fista` #5

Closed zaccharieramzi closed 5 years ago

zaccharieramzi commented 5 years ago

Some arguments of the function sparse_rec_fista are unused variables:

nb_scales
atol
lambda_init

The first 2 are misleading, because their use is actually elsewhere (respectively when creating the linear operator and when creating the cost operator).

The last one should be used when initializing the opt object.

chaithyagr commented 5 years ago

@zaccharieramzi , I am assuming this issue can be closed?

zaccharieramzi commented 5 years ago

Yes.