search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Implements the undersampling of kspace z direction #58

Closed mathrip closed 4 years ago

mathrip commented 5 years ago

This PR implements the undersampling of the k-space in the z-direction (only working for the stacks implementations).

This solves #56 as the z-dimension has been cropped, it also solves #33

chaithyagr commented 4 years ago

We may have to rebase this completely. This could be a hard task, based on changes we can as well take a new branch and do it manually. @mathrip do you want to do this? Or shall I take over?

chaithyagr commented 4 years ago

Taking over for rebasing and ensuring this is at mainline

chaithyagr commented 4 years ago

I have rebased all the codes to master. @zaccharieramzi can you please do a final check? I will merge once I have tests passing

zaccharieramzi commented 4 years ago

@mathrip have you had the chance to re-read the rebased version?

mathrip commented 4 years ago

@mathrip have you had the chance to re-read the rebased version?

Not yet, but I'll do it tomorrow !

mathrip commented 4 years ago

@mathrip have you had the chance to re-read the rebased version?

I reviewed and I approve @zaccharieramzi can you approve it? Thanks