Undefined variable when extracting sensivity maps

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package

Other

43 stars 18 forks source link

Undefined variable when extracting sensivity maps #75

Closed Daval-G closed 4 years ago

Daval-G commented 4 years ago

I was trying to run the example "SelfCalibrationReconstruction_Cartesian.py" but changed the Fourier operator (and the data accordingly) to a Stacked3DNFFT to test it.

The reconstructor raised an error because the variable z_sample_loc was not defined in: https://github.com/CEA-COSMIC/pysap-mri/blob/c39764bf07c8dbefdb60c4e0be92fa3f96b477e2/mri/reconstructors/utils/extract_sensitivity_maps.py#L166

It may be related to a previous issue: https://github.com/CEA-COSMIC/pysap-mri/issues/62

chaithyagr commented 4 years ago

This seems to be an atifact of moving to new functions for accomodating variable kspace z lines in #58 I will get a PR for fixing this and #72 . Also, I will add tests to ensure we dont miss this in future thereby increasing coverage also

chaithyagr commented 4 years ago

Fixed with #76