search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Extend SelfCalibrationReconstructor smaps use, add getter and setter #79

Closed Daval-G closed 4 years ago

Daval-G commented 4 years ago

This fixes issue #77 by adding sensivity maps as an optional argument to SelfCalibrationReconstructor during initialization. It also adds a getter and a setter for those sensivity maps with the appropriate documentation, in order to retrieve more easily the maps after a long computation.

The capital letter of the Smaps argument was kept to be coherent with the gradient operator Smaps argument, and to avoid unexpected behaviors by for example giving smaps as regular argument and Smaps in kwargs during SelfCalibrationReconstructor initialization.

chaithyagr commented 4 years ago

Also @Daval-G , the Travis tests are failing for 2 reasons: 1) Bad usage of set_smaps() 2) Bad docstrings due to which docs couldnt be rightly generated. Can you please look into it? (You can find logs here: https://travis-ci.org/CEA-COSMIC/pysap-mri/builds/645384188?utm_source=github_status&utm_medium=notification)

chaithyagr commented 4 years ago

Looks like everything is resolved, @Daval-G please Squash and Merge when tests pass and everything is green