CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

changed self calibration gradients op to not use loop #94

Closed zaccharieramzi closed 4 years ago

zaccharieramzi commented 4 years ago

small efficiency gain I didn't write an issue for this since this is so minor

chaithyagr commented 4 years ago

Thank you Zac. This seems to have missed in efficiency, as I think maybe the code was kept readable and loops tend to be the first approach to a problem. I dont this there is much to review here. I will just run codes, and for sake of documentation, just write down the change in speed after this update in example codes. By then I hope CI will be complete and I will merge it.