search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

Add SWI Reconstruction of data from multichannel #96

Closed mathrip closed 2 years ago

mathrip commented 4 years ago

Fix some errors encountered when processing SPARKLING data + add function to process SWI contrast images.

References :

chaithyagr commented 4 years ago

@mathrip I have converted the PR to a draft for now, to prevent emails to others. Once you think the PR is complete in your opinion and ready for review, for this I recomment you ensure that the docs are building fine, and also that PEP8 errors are good, please click on Ready for Review.

chaithyagr commented 4 years ago

@mathrip any updates? There are still some changes left based on code. Also, can you please rename your file to have a .py extension, and add the appropriate LICENSE related header information?

chaithyagr commented 3 years ago

This is increasingly getting stale, @Daval-G can you please ensure you have all codes from here in your codes? In which case, we can close this perhaps?

chaithyagr commented 3 years ago

This is increasingly getting stale, @Daval-G can you please ensure you have all codes from here in your codes? In which case, we can close this perhaps?

@Daval-G ? Can we close this as you will have this in #115 ?

Daval-G commented 3 years ago

This is increasingly getting stale, @Daval-G can you please ensure you have all codes from here in your codes? In which case, we can close this perhaps?

@Daval-G ? Can we close this as you will have this in #115 ?

I don't actually intend to add SWI-related code in #115. I feel that current PR should still be good to merge.

chaithyagr commented 2 years ago

We can maybe close this PR as it is stale. @Daval-G can you handle adding up to date version of these features and an example so that we can use it (or does it already exist?) Closing this here..