CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

[Enhancement][BUG] Send Linear operator to POGM so that metrics can be called #98

Closed chaithyagr closed 4 years ago

chaithyagr commented 4 years ago

Current implementation of POGM in pysap-mri does not pass the linear_op to the optimizer due to which it is internally set to Identity. However, as POGM carries out complete optimization on the wavelet coefficients, the SSIM metric calculations needs the adjoint operation which is performed here:

https://github.com/CEA-COSMIC/ModOpt/blob/f9aa7b6154bfe34bc79d94d3c7d03350d47eef4a/modopt/opt/algorithms.py#L1347-L1356

However, for this, the linear operator must be set right which isnt done right in current scenario. This prevents faster iterations of retrospective studies and also a better grid search.

Tagging as a bug to just raise the importance of the issue.