search

CEA-COSMIC / pysap-mri

MRI external plugin for Python Sparse data Analysis Package
Other
43 stars 18 forks source link

[SHORT] Pass linear_op to POGM #99

Closed chaithyagr closed 4 years ago

chaithyagr commented 4 years ago

This is a quick single line PR to ensure that metrics can be used right with POGM. This resolves #98 .

Adding @zaccharieramzi for a quick review as he wrote POGM initially.

chaithyagr commented 4 years ago

Looks like a random crash. I will squash merge once green. Thank you @zaccharieramzi for the review.

chaithyagr commented 4 years ago

The failure is for Python 3.5, looks like Scikit-Learn is no longer supporting python 3.5 Even the master branch is failing with same issue.

@zaccharieramzi shall we also remove travis from testing in python 3.5 and start testing on Python 3.8? Maybe I could add this to current PR, as this is currently just a single line change.

zaccharieramzi commented 4 years ago

@chaithyagr I say let's have another PR for this just to be clean

chaithyagr commented 4 years ago

Sure, although this must not be happening, I see this as a separate issue in pysap. It looks like doing python setup.py install, is triggering easy_install, which isnt handling the dependencies well, mostly that too in Travis. Let me dig a bit deeper into this.

chaithyagr commented 4 years ago

Merging again, as 2 CIs have passed