search

CEA-COSMIC / pysap

Python Sparse data Analysis Package
Other
54 stars 24 forks source link

[BUG] Unaccessible Second Generation of Starlet #103

Open fadinammour opened 5 years ago

fadinammour commented 5 years ago

System setup OS: macOS v10.14.5 Python version: v3.7.3 Python environment : conda v4.7.10

Describe the bug In the C++ code, the boolean ModifiedATWT allows the user to switch from the First Generation Starlet to the Second one. However in the associated Python code, he cannot get the filters of the Second Generation because it seems that he does have access to this boolean variable.

Module and lines involved The missing boolean variable should be an argument of get_mr_filters() in ModOpt/modoptt/signal/wavelet.py. And it can be found in Sparse2D/MR_Filter.cc and its role is explained in the comment of line 851.

Are you planning to submit a Pull Request?

aymgal commented 4 years ago

Hi! do you plan to add support for 2nd gen starlet ? Same question for Battle-Lemaré wavelet transform, as I know it is implemented in sparse2d (used in glimpse).

sfarrens commented 4 years ago

Hi @aymgal, I am planning to make some updates to PySAP this autumn, so I can look into.

aymgal commented 4 years ago

That would be awesome, thank you