search

CECTC / dbpack

A db proxy for distributed transaction, read write splitting and sharding! Support any language! It can be deployed as a sidecar in a pod.
https://cectc.github.io/dbpack-doc/#/en-us/
Apache License 2.0
356 stars 46 forks source link

fix: xa commit/rollback should executed by master conn in read write … #280

Closed dk-lockdown closed 1 year ago

dk-lockdown commented 1 year ago

…splitting mode

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter commented 1 year ago

Codecov Report

Merging #280 (0304ad2) into dev (1d12859) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #280      +/-   ##
==========================================
- Coverage   42.54%   42.52%   -0.02%     
==========================================
  Files          91       91              
  Lines       10470    10473       +3     
==========================================
  Hits         4454     4454              
- Misses       5527     5530       +3     
  Partials      489      489
Impacted Files Coverage Δ
pkg/executor/read_write_splitting.go 42.00% <0.00%> (-0.59%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more