Follow up for PR 152 - Githubissues

CEED / Laghos

High-order Lagrangian Hydrodynamics Miniapp

http://ceed.exascaleproject.org/miniapps

BSD 2-Clause "Simplified" License

189 stars 61 forks source link

Follow up for PR 152 #154

Closed siuwuncheung closed 3 years ago

siuwuncheung commented 3 years ago

Fix failing regression tests caused by last commits in PR 152. Only allocate memory, record RK stages and store in sampler if -sample-stages is used
Add an option -soldir of solution subdirectory to allow multiple FOM run to save FOM solution under the same output directory simultaneously. This is used for parametric tests.

siuwuncheung commented 3 years ago

@kevinhkhuynh @dylan-copeland @chldkdtn This small PR is ready for review. It is to repair the failing regression tests and add a small capability to facilitate the long-time parametric simulations.

dylan-copeland commented 3 years ago

@siuwuncheung I just tried to run the regression tests, and they all fail (even offline) with seg faults. Do they pass for you?

siuwuncheung commented 3 years ago

@siuwuncheung I just tried to run the regression tests, and they all fail (even offline) with seg faults. Do they pass for you?

Thanks Dylan. The tests fail because the runs are unsuccessful in the baseline branch after we merge PR 152. This small PR is to repair the failures caused by the last few commits in PR 152. As Kevin suggested, the best we can do now is to run the regression test with -t option to test the branch against itself, since the baseline is broken.