search

CEED / Laghos

High-order Lagrangian Hydrodynamics Miniapp
http://ceed.exascaleproject.org/miniapps
BSD 2-Clause "Simplified" License
182 stars 59 forks source link

Reformat with AStyle-3.1 #157

Closed tzanio closed 3 years ago

tzanio commented 3 years ago

MFEM switched to AStyle-3.1 in https://github.com/mfem/mfem/pull/2506.

This PR applies the new formatting in Laghos.

tzanio commented 3 years ago

@vladotomov, do we know why the test are failing?

vladotomov commented 3 years ago

Because master is failing, I'm looking at it.

camierjs commented 3 years ago

There is 1D support that is required for some 1D test to work.

vladotomov commented 3 years ago

./laghos -p 2 -dim 1 -rs 5 -tf 0.2 -fa -vs 100

MFEM abort: Kernel not supported yet ... in function: void mfem::internal::quadrature_interpolator::TensorValues(const int, const int, const mfem::DofToQuad &, const mfem::Vector &, mfem::Vector &) ... in file: fem/qinterp/eval_by_vdim.cpp:98

@camierjs does this look familiar, seems that we've switched to going to 1D kernels even with -fa?

camierjs commented 3 years ago

Yes, we defaulted to use the tensor functions. I started to add the 1D support in the qeval1d MFEM branch.

tzanio commented 3 years ago

I'll merge this PR, because it is orthogonal to the 1D failure, but we should open an issue about that so we don't forget.