search

CEED / Laghos

High-order Lagrangian Hydrodynamics Miniapp
http://ceed.exascaleproject.org/miniapps
BSD 2-Clause "Simplified" License
187 stars 60 forks source link

Update for libROM PR 261 #184

Closed dylan-copeland closed 8 months ago

cval26 commented 8 months ago

Are the new libROM function interfaces backward compatible? Namely, if the time and timestep values are not removed from existing function calls, will that produce an error? Or have they been kept as default argument variables that are simply not used within libROM?

dylan-copeland commented 8 months ago

Are the new libROM function interfaces backward compatible? Namely, if the time and timestep values are not removed from existing function calls, will that produce an error? Or have they been kept as default argument variables that are simply not used within libROM?

The interface had a breaking change in libROM PR 261, i.e. it is not backward compatible. It is necessary to remove the time and timestep from the function calls, in order to compile. The changes are not too bad, as seen in this PR.