CEED / libCEED

CEED Library: Code for Efficient Extensible Discretizations
https://libceed.org
BSD 2-Clause "Simplified" License
198 stars 47 forks source link

minor - drop unneeded casts #1667

Closed jeremylt closed 1 week ago

jeremylt commented 1 week ago

oops

jrwrigh commented 1 week ago

For the errors on Noether in the fluids example:

[WARNING] yaksa: 1 leaked handle pool objects

I've only recently seen those on Aurora. Possibly due to latest PETSc main?

jeremylt commented 1 week ago

Yeah, looks like PETSc is leaking something somewhere maybe? Its for all PETSc examples

jeremylt commented 1 week ago

This isn't expressing in Ratel CI - I wonder if there's something fishy with the int64 builds on Noether? Or maybe a package included?

jeremylt commented 1 week ago

Hmm, tried setting the opt flags to O2 since MPI is supposed to clean up everything at higher optimization levels, but it doesn't seem to have helped. This error is, according to my initial research, supposed to show when there is a missing MPI_Type_Free https://github.com/pmodels/yaksa/discussions/254

jeremylt commented 1 week ago

Confirmed, this only occurs for the int64 build, and not the int32 build, and this is with and without HIP that we see the issue