search

CEMPD / SMOKE

Create emissions inputs for multiple air quality modeling systems with unmatched speed and flexibility
https://www.cmascenter.org/smoke/
45 stars 21 forks source link

LFIP initialization inconsistent #42

Closed barronh closed 2 years ago

barronh commented 2 years ago

In rdemspd.f, the LFIP variable is declared as an integer and then initialized as a zero-length string. gfortran throws an error, which seems appropriate (see below).

Makefile:351: recipe for target 'rdemspd.o' failed
/content/subsys/smoke/src/smkinven/rdemspd.f:304:15:

         LFIP = ''
               1
Error: Can't convert CHARACTER(1) to INTEGER(4) at (1)
make: *** [rdemspd.o] Error 1

In rdorlfr.f, the same problem occurs. In rdff10pd.f, LFIP is a character so no problem there or in rdmedspd.f. I have no idea what value ifort gives LFIP when set to '', but perhaps you could just initialize with that integer value.

bokhaeng commented 2 years ago

Hi Barron. You are correct. That bug has been fixed last Dec 2020. Here is the fix. If you update the SMOKE to the latest version, that issue will be addressed or you can update your version with this fix.

barronh commented 2 years ago

Sorry for not seeing the update. I thought I was pulling from the latest release. Thanks

barronh commented 2 years ago

FYI - I am pulling from the https://github.com/CEMPD/SMOKE/archive/refs/tags/SMOKEv481_Jan2021.tar.gz.