search

CEMPD / VERDI

This is the repo for the VERDI project, written in java.
GNU General Public License v3.0
16 stars 13 forks source link

The purpose of the "Domain" window in the Datasets panel #320

Open dkang2 opened 1 year ago

dkang2 commented 1 year ago

Is your feature request related to a problem? Please describe. There are two press buttons in the "Domain" window on the "Datasets Panel": "Edit Me" and "Metadata Me". I'm not clear what these two buttons for? When I click on them, nothing happens. And when searching the Verdi Manual, nothing popping up either.

Describe the solution you'd like Either add some functions to these buttons, or delete the window altogether? I guess that there must be some initial thinking to include this window. Or if these buttons are already associated with some functions, please describe it in the manual.

Describe alternatives you've considered If no functions are associated at this time, maybe just remove the window.

Additional context Add any other context or screenshots about the feature request here.

image
dkang2 commented 1 year ago

After further testing with other datasets, in fact that if click "Metadata Me", a window pops up to show the metadata of the dataset and it is nice. This feature should be kept, but the space under the buttons don't show anything. If it is the case, we may just keep the "Metadata Me" button.

image
dkang2 commented 1 year ago

The "Metadata Me" works with CMAQ/WRF netcdf formats, but it doesn't work with MPAS data format. It would be nice to implement this for MPAS data, too.

yadongxuEPA commented 1 year ago

Retested VERDI 2.1.4 20230831 builds on Atmos, found that this issue has not resolved. Actually the "Domain" GUI has disappeared (tested with loading a CMAQ dataset and a MPAS dataset). issue_320_load_CMAQ_dataset issue_320_load_MPAS_dataset

dkang2 commented 1 year ago

This VERDI 2.1.4 20230911 build has restored earlier features, but the issue hasn't been addressed.

image
yadongxuEPA commented 12 months ago

Retested VERDI 2.1.4 20230911 and 20230924 builds on Atmos, found that this issue has resolved. Now the "Domain" GUI has been removed from Datasets Tab.

lizadams commented 7 months ago

Testing with VERDI_2.1.5_mac_20240124.tar.gz

I am confused, we say in the Release notes that the following has been done:

"Enable "Metadata Me" for MPAS (#320)"

But the Domain GUI has been removed, so this option is no longer supported.

yadongxuEPA commented 7 months ago

Testing with VERDI_2.1.5_mac_20240124.tar.gz

I am confused, we say in the Release notes that the following has been done:

"Enable "Metadata Me" for MPAS (#320)"

But the Domain GUI has been removed, so this option is no longer supported.

Hi Liz,

Thanks for re-testing and double-checking the issues. That's a good catch for #320. I think that we changed the work scope for this issue. Initially we wanted to enable "Metadata Me" feature for MPAS, but later we decided to simply remove the "domain" window. At this point, I think we definitely need to update the release note for VERDI 2.1.5. And keep this issue open if we still want to enable "Metadata Me' feature for MPAS in the future.

lizadams commented 7 months ago

I've updated the Release Notes on the main branch to reflect this:

https://github.com/CEMPD/VERDI/blob/master/doc/Release_Notes/README.md