search

CEMPD / VERDI

This is the repo for the VERDI project, written in java.
GNU General Public License v3.0
16 stars 13 forks source link

Support sub-domain on a Vertical Cross Section Plot #326

Closed yadongxuEPA closed 7 months ago

yadongxuEPA commented 1 year ago

Is your feature request related to a problem? Please describe. Yes, this issue was first reported on CMAS forum by a user under this link https://forum.cmascenter.org/t/verdi-cross-section-plot-in-script/4156/3

I confirmed this issue using the command line described as below and got the same error: image

Describe the solution you'd like Add "subDomain" as one of the argument options for "verticalCrossPlot". Just like what we have for a tile plot. See the example as below: image

image

lizadams commented 1 year ago

Another issue on this has been posted to the CMAS Center Forum. https://forum.cmascenter.org/t/how-can-i-use-subdomain-command-for-crossplot-in-verdi/4299

yadongxuEPA commented 1 year ago

Retested VERDI 2.1.4 20230831 builds on Atmos, found that this issue has improved, but not fully resolved yet. 1) the error messages are more clearer now if user chose a row number is lower than the minimum Y set after "-subDomain" issue_326_vertical_cross_section_in_script_error_message 2) When user chose a correct row number. For example, "Y 70" as shown below, somehow, VERDI loaded a vertical cross section plot at "row 31" image issue_326_vertical_cross_section_in_script_Y_70_commandline 3) Tried to use the following script by set the row number to 70, surprisingly the saved vertical cross section plot went to "row 31". image issue_326_vertical_cross_section_in_script_Y_70 Users actually want the saved image only display the vertical cross plot between the columns set between "Xmin" and "Xmax", in this example, it should be between 20-60 on X-axis instead of 1-141.

yadongxuEPA commented 12 months ago

Retested VERDI 2.1.4 20230911 builds on Atmos, found that this issue has not resolved, we still have the same issues with the 20230831 builds as described above.

yadongxuEPA commented 11 months ago

Retested VERDI 2.1.4 20230924 builds on Atmos, confirmed that this issue has resolved. Tested two ways with "-subDomain": 1) in command line: ./verdi.sh -f /work/MOD3APP/yxu/VERDI_2.1.4/data/model/CCTM46_P16.baseO2a.36k.O3MAX -s "O3[1]" -subDomain 20 40 60 80 -verticalCrossPlot Y 70 Github_issue_326_command_line 2) in a script: image Github_issue_326_in_script

yadongxuEPA commented 11 months ago

Retested VERDI 2.1.4 20231012 builds on Atmos, confirmed that this issue has resolved.

yadongxuEPA commented 8 months ago

Checked VERDI_2.1.5_linux64_20231222.tar.gz on Atmos and it worked.

lizadams commented 8 months ago

Tested using VERDI_2.1.5_mac_20240103.tar.gz

./verdi.sh -f $cwd/data/model/CCTM46_P16.baseO2a.36k.O3MAX -s "O3[1]" -subDomain 20 40 60 80 -verticalCrossPlot Y 70

The vertical cross section plot was successfully created.

lizadams commented 7 months ago

Re-tested using VERDI_2.1.5_mac_20240124.tar.gz, vertical cross section plot was successfully created

yadongxuEPA commented 7 months ago

Checked VERDI 2.1.5 20240124 builds on Atmos, confirmed that it worked.