search

CEMeNT-PSAAP / MCDC

MC/DC: Monte Carlo Dynamic Code
https://mcdc.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
20 stars 20 forks source link

Installation issue #170

Closed lewisfish closed 5 months ago

lewisfish commented 5 months ago

Hi MCDC team, I'm one of the reviewers working on reviewing your JOSS submission https://github.com/openjournals/joss-reviews/issues/6415.

Currently following the instructions in the README and the readthedocs webpage fails to install the package. Currently on creating a Conda env, cloning the repo and running bash install.sh gives:

CommandNotFoundError: No command 'conda mpi4py'.

I see from PR #162 and #165 it has been fixed but not merged into the main branch. Can this be merged into the main branch so I can tick off the installation item on my review list?

jpmorgan98 commented 5 months ago

I opened a PR, when the CI finishes I'll have some one merge it. Thanks!

jpmorgan98 commented 5 months ago

Everything is merged thanks @lewisfish!!!!!