CEMeNT-PSAAP / MCDC

MC/DC: Monte Carlo Dynamic Code
https://mcdc.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
20 stars 20 forks source link

Numba does not reproduce Python results #190

Open ilhamv opened 4 months ago

ilhamv commented 4 months ago

Numba does not reproduce the Python result for cooper2 in the regression test. The difference comes only from work index 17 (idx_work == 17 in loop.py). The issue only shows up if run with the original problem reflective BCs AND mcdc.implicit_capture.

The current, temporary, "fix" is to turn off the implicit capture.

The recommended action is to locate the issue by following all tally scorings happening in the said work index.

ilhamv commented 3 weeks ago

The issues showed up in #186. I'll get back to it when it is time to merge the optimizations.