Refactor CSG tracking with Reverse Polish Notation

CEMeNT-PSAAP / MCDC

MC/DC: Monte Carlo Dynamic Code

https://mcdc.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

23 stars 24 forks source link

Refactor CSG tracking with Reverse Polish Notation #222

Closed ilhamv closed 2 months ago

ilhamv commented 3 months ago

The CSG tracking is refactored from a recursion of function calls into an algorithm based on the Reverse Polish Notation (Thanks, @braxtoncuneo, for the suggestions!). This fixes the GPU runtime error (#206) which turns out to be caused by the function recursions.

jpmorgan98 commented 2 months ago

You ran this on the nivida development system, right?

ilhamv commented 2 months ago

You ran this on the nivida development system, right?

Yes, I tested it on the mcdc-env you set up in the OSU ssh. But it would be great if you can double-check to be very sure.

jpmorgan98 commented 2 months ago

Everything passes!