[BUG/ISSUE] Health Scaling Issues with Scaling Health Mod

[yakusai]

Before submitting the issue

• [x] I have checked that the bug is not a duplicate or, if it is, it needs to be reopened
• [x] I have checked that I am running the latest version of Bosses of Mass Destruction [FORGE] Mod
• [x] I have checked the FAQ section for solutions
• [x] I have read the contributing guidelines and I agree with the Code of Conduct

Minecraft Version

1.20.1

Describe the bug

When used alongside the Scaling Health mod to multiply the HP values of mobs, none of the bosses from Bosses of Mass Destruction scale properly. For example, under the circumstances where every other monster would gain 5 times their health, BOMD bosses seem to gain a noticeably smaller amount (around 2.5 times their health instead from what I've observed). This is noticeable at all multiplier values that you would set Scaling Health to. This is able to be recreated in both a heavily modded Minecraft, and a modpack consisting of just Scaling Health, BOMD, Jade, and JEI.

The HP scaling has also been tested with other modded bosses, such as ones from Cataclysm and the Twilight Forest, and only BOMD has issues with lesser HP scaling.

To Reproduce

Steps to reproduce the behavior:

1. Install both the Scaling Health and BOMD mods.
2. Also install Attribute Fix so that max mob health can go beyond 1024, as well as a mod to numerically track enemy HP values.
3. Create a datapack for Scaling Health which modifies its hostile mob HP multiplier to 1.0 to simplify the multiplier.
4. Load or create a Minecraft world with cheats.
5. Set /sh_difficulty for yourself to 80, which will ensure mob HP is multiplied by 5x (can be tested by spawning a ravager, which should go from 100 HP to around 500 HP)
6. Spawn any BOMD boss, such as the Void Blossom
7. Notice that the Void Blossom (and any other BOMD boss) spawns with roughly 2.5x their base HP instead of 5x.

Expected behavior

Any BOMD boss summoned after setting the multiplier to 5x should have their HP scaled to 5x. Instead it only seems to scale to 2.5x. Scaling with other multipliers such as 10x seem to give a similar effect, but with ~200 less HP than the desired amount

Latest Log

No relevant log information that I could find.

Any insight into this issue would be very much appreciated. For now, I will have to just avoid all BOMD bosses on my custom server, or remove the bugged ones and spawn new bosses with much higher HP scaling/difficulty values. Thank you in advance!

[CerbonXD]

Can you please send me the datapack you are using? I never used this mod before so having the datapack set up to test would be really appreciated.

[yakusai]

Oh, of course. Here you go. It may have other things I configured such as removing certain item spawns, but nothing that should affect testing. I'm no expert at the mod, since I just started using it myself, but let me know if you need anything else. Though I'm off to bed soon, so probably won't reply for a bit. Oh, and thank you for the fast response and also your willingness to try and help! scalinghealthpack.zip

[yakusai]

I have also just tested separate calculations with another mod, Majrusz's Progressive Difficulty mod, which also allows you to easily multiply enemy HP values through its config file via the "health_bonus" attribute. It turns out that Majrusz's multiplies BOMD boss HP correctly, and setting 9.0 to the default health_bonus attribute properly adds +900% HP to the BOMD bosses (Void blossom goes from 350 to 3500 HP properly). So this seems to be some problem specific to the combination of the Scaling Health mod and the BOMD. Why this is I am unsure, since Scaling Health multiplies HP values correctly for all other mobs I've tested.