search

CERIT-SC / puppet-serial_console

Puppet module for system serial console setup
MIT License
1 stars 8 forks source link

Fix case statement for puppet 4 #6

Closed mjrasobarnett closed 8 years ago

mjrasobarnett commented 8 years ago

Hello, I've just come across your module (great work!) and am incorporating into my environment which is using Puppet 4.5.1 and facter 3.2.0 and I had compile errors like the following:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Function Call, Unsupported OS version: RedHat 6 at /etc/puppetlabs/code/environments/grub/mod ules/serial_console/manifests/params.pp:49:11

I believe that facter in Puppet 4 is returning the osfamily fact differently to before perhaps using CamelCase, so I've updated CentOS and RedHat to reflect this (I only have systems with these two OS to test on). I also added quotes around the case statement values as that caused another compile error for me.

vholer commented 8 years ago

Thank you, I have merged your changes. I'll release new module on Puppet Forge soon.