CERIT-SC / puppet-tuned

Puppet module for Tuned
MIT License
0 stars 21 forks source link

migrate legacy validate functions to puppet type system #6

Closed duritong closed 6 years ago

duritong commented 7 years ago

Get rid off deprecation warnings from stdlib.

Requires puppet >=4, but Puppet 3 was anyways EOL last year.

ggeldenhuis commented 6 years ago

Any chance of getting this merged? This module seems to be the most actively developed tuned module and a cursory glance reveals good quality code. Getting this PR merged will help encourage further contributions.

sammcj commented 6 years ago

++ would be keen to see this merged!

ping @vholer

vholer commented 6 years ago

Thank you, I'll check and merge the changes by the end of the week. Thank you for patience.

vholer commented 6 years ago

Thank you, merged.

I have made few more changes to refresh the module for new Puppet. I'm giving it 3 days (in case you want to try it, or comment), then I'll release new module on Puppet Forge. Thanks a lot!