CERIT-SC / puppet-yum

Puppet module for Yum
MIT License
6 stars 114 forks source link

Yum Versionlock validation is wrong #6

Open 02strich opened 10 years ago

02strich commented 10 years ago

The validation of the name parameter enforces the specification of an epoch, which is not required in RPM as packages do not need to have an epoch value.

vholer commented 9 years ago

I believe it's required, see man yum-versionlock:

   /etc/yum/pluginconf.d/versionlock.list
          The default place to put  package  version  lock  information  (one
          package  and version per. line). The file takes entries in the fol-
          lowing format EPOCH:NAME-VERSION-RELEASE.ARCH See rpm(8)  for  more
          information  on  custom query formats. If the package does not have
          an EPOCH the number will default to 0.

It's good to follow this format otherwise version locking doesn't work or works strange. And I would better not prefix package with default epoch "0:" if missing...

02strich commented 9 years ago

I actually no longer have the test case available which triggered creating this issue, but I believe the last sentence from the quote did not work or did so in an unexpected way. What is you reason for not making the epoch optional (and thereby following RPM)?