CERN-CERT / pDNSSOC

Leveraging MISP indicators via a pDNS-based infrastructure as a poor man’s SOC.
MIT License
49 stars 5 forks source link

Empty 'output_dir/matches.json' causing errors #18

Open romainw opened 9 months ago

romainw commented 9 months ago

It seems 'output_dir/matches.json' does not exist at least when creating a new instance, which is causing errors:

dnscollector_1  | Exception in thread Thread-8 (daemonized_correlate):
dnscollector_1  | Traceback (most recent call last):
dnscollector_1  |   File "/usr/local/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
dnscollector_1  |     self.run()
dnscollector_1  |   File "/usr/local/lib/python3.11/threading.py", line 982, in run
dnscollector_1  |     self._target(*self._args, **self._kwargs)
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/pdnssoccli/subcommands/daemonize.py", line 34, in daemonized_correlate
dnscollector_1  |     ctx.invoke(correlate)
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
dnscollector_1  |     return __callback(*args, **kwargs)
dnscollector_1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
dnscollector_1  |     return f(get_current_context(), *args, **kwargs)
dnscollector_1  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/pdnssoccli/subcommands/correlate.py", line 289, in correlate
dnscollector_1  |     with jsonlines.open(Path(correlation_config['output_dir'], "matches.json"), mode='a') as writer:
dnscollector_1  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dnscollector_1  |   File "/usr/local/lib/python3.11/site-packages/jsonlines/jsonlines.py", line 643, in open
dnscollector_1  |     fp = builtins.open(file, mode=mode + "t", encoding=encoding)

Maybe this file should be created, even empty, during installation?