CERN-PH-CMG / cmg-cmssw

CERN CMG Tools repository. Installation instructions available on the twiki:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMGToolsReleasesExperimental
19 stars 244 forks source link

Electron / photon scale and resolution corrections for ICHEP 2016 #664

Closed emanueledimarco closed 8 years ago

emanueledimarco commented 8 years ago

Implemented the corrections from https://twiki.cern.ch/twiki/bin/viewauth/CMS/EGMSmearer To use them, you need to:

To configure the corrections

schoef commented 8 years ago

@emanueledimarco

thanks a lot. era should be '25ns', sync should be False. I sanity-tested the PR, change in pt for photon, electron is within expectation.

emanueledimarco commented 8 years ago

@schoef yes, sorry, I omitted the values for those parameters. They are like you say. I also tested it and it runs, but I am now running on full DoubleEG and SinglePhoton to make a more extensive validation (also because there were rare crashes)

schoef commented 8 years ago

@emanueledimarco OK, please let me know because I'm about to launch a full scale tupelization Thanks for the heads-up

emanueledimarco commented 8 years ago

And this should also fix the other problem reported by Philipp, i.e. that if the category is not found, the corrector tried to access an incorrect memory location, corrupting in irreproducible way the subsequent modules (electron ID modules, for example)

schoef commented 8 years ago

@emanueledimarco I processed almost all available mAODv2 with this branch (including f38d7ff ) and have so far not seen a failure.

emanueledimarco commented 8 years ago

I have also validated the scale and resolution corrections on the golden JSON with 7.65 fb-1 and they work as expected.