search

CERN-PH-CMG / cmg-cmssw

CERN CMG Tools repository. Installation instructions available on the twiki:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMGToolsReleasesExperimental
19 stars 244 forks source link

Lepton isolation update 2 #741

Closed cbernet closed 6 years ago

cbernet commented 6 years ago

Hello, in this pull request, I'm taking over from Gael Touquet for PR #738, which can be closed.

@gpetruc thank you again for your comments. As you requested, the effective areas can now be provided:

  1. to the isolation methods
  2. to the lepton object
  3. to the lepton class

The effective area is searched for in this order. We use solution 3 in our analysis configuration, like this: 

Electron.EffectiveArea03 = areas['Fall17']['electron']
Electron.iso_htt = lambda x: x.relIso(0.3, "EA", 
                                      all_charged=False)

There is a new EffectiveAreas.py module where they are defined in a global dictionary, that can be easily accessed. For now, this dictionary contains the values that are in the LeptonAnalyzer for the electron.

I didn't want to modify the LeptonAnalyzer at this stage, but if you want, in a second pull request after this one is merged, I can:

In the next PR, I can also remove the obsolete methods in Lepton.py

Testing done:

Please let me know if you have any further comments.

@GaelTouquet @lucastorterotot

cbernet commented 6 years ago

Yep. I will base my PR on 94X_dev. If you want me to use another branch, let me know.

Colin

Le 13 sept. 2018 à 12:14, Giovanni Petrucciani notifications@github.com a écrit :

@gpetruc requested changes on this pull request.

The function rename would also break these files in CMGTools-lite

HToZZ4L/python/analyzers/zzTypes.py TTHAnalysis/python/analyzers/ttHTypes.py (@peruzzim https://github.com/peruzzim) VVResonances/python/tools/VectorBosonToolBox.py (@clelange https://github.com/clelange) So, please prepare also a minimal PR for cmgtools-lite with the changes to those files (xxxIsoR → xxxIso), to be merged at the same time.

In PhysicsTools/Heppy/python/physicsobjects/Electron.py https://github.com/CERN-PH-CMG/cmg-cmssw/pull/741#discussion_r217328313:

@@ -565,29 +564,26 @@ def hltPFIso(self,isoType): else: isoValue = -999 return max(0, isoValue - self.rhoHLT*hltEA)

In PhysicsTools/Heppy/python/physicsobjects/Electron.py https://github.com/CERN-PH-CMG/cmg-cmssw/pull/741#discussion_r217330248:

@@ -565,29 +564,26 @@ def hltPFIso(self,isoType): else: isoValue = -999 return max(0, isoValue - self.rhoHLT*hltEA)

  • def chargedHadronIsoR(self,R=0.4):
  • def chargedHadronIso(self,R=0.4): and also:

https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/analyzers/objects/autophobj.py#L89-L90 https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/analyzers/objects/autophobj.py#L89-L90 https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/physicsobjects/Electron.py#L643-L661 https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/physicsobjects/Electron.py#L643-L661 https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/physicsobjects/Muon.py#L148-L166 https://github.com/CERN-PH-CMG/cmg-cmssw/blob/heppy_94X_dev/PhysicsTools/Heppy/python/physicsobjects/Muon.py#L148-L166 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CERN-PH-CMG/cmg-cmssw/pull/741#pullrequestreview-155012038, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8ku9PyRxhHN8Fn3AtRfg2DDmbI8F83ks5uai_3gaJpZM4Wg1fL.

cbernet commented 6 years ago

I think it's all done, thank you for the review