search

CERN / TIGRE

TIGRE: Tomographic Iterative GPU-based Reconstruction Toolbox
BSD 3-Clause "New" or "Revised" License
573 stars 188 forks source link

iterative_recon_alg: switch l2l to numpy array #309

Closed Scriptkiddi closed 3 years ago

Scriptkiddi commented 3 years ago

308

AnderBiguri commented 3 years ago

Thanks! Will test and merge :)

AnderBiguri commented 3 years ago

Sorry for the delay.

I think it would make sense to change the following too:

https://github.com/CERN/TIGRE/blob/ff50fede05ccfa41584bb47e81033adfd5492938/Python/tigre/algorithms/iterative_recon_alg.py#L212

Would you mind doing and testing that?

Scriptkiddi commented 3 years ago

I'm sorry but I can not follow, did you link to the correct commit? If you mean the change I did, I have tested it.

AnderBiguri commented 3 years ago

@Scriptkiddi yes, you made this change:

https://github.com/CERN/TIGRE/blob/ff50fede05ccfa41584bb47e81033adfd5492938/Python/tigre/algorithms/iterative_recon_alg.py#L213

and I was suggesting that the previous line

https://github.com/CERN/TIGRE/blob/ff50fede05ccfa41584bb47e81033adfd5492938/Python/tigre/algorithms/iterative_recon_alg.py#L212

May require the exact same change, and if you were willing to change and test it out :)

Scriptkiddi commented 3 years ago

Ah got it will go and check

Scriptkiddi commented 3 years ago

Fixed it, all other list initialization seem to be ok

AnderBiguri commented 3 years ago

Thanks for the help and the work! I will test and merge!