Improve numerical accuracy of forward projection (Siddon algorithm)

CERN / TIGRE

TIGRE: Tomographic Iterative GPU-based Reconstruction Toolbox

BSD 3-Clause "New" or "Revised" License

550 stars 182 forks source link

Improve numerical accuracy of forward projection (Siddon algorithm) #368

Closed cschreib-ibex closed 2 years ago

cschreib-ibex commented 2 years ago

WIP

cschreib-ibex commented 2 years ago

Sorry, I did not mean to open the PR in this repo :( This is still very much work-in-progress too! Will come back here when we're more confident in the change.

AnderBiguri commented 1 year ago

hey @cschreib-ibex , did you end up sorting this out in your end? Recently someone has been complaining about errors that look numerical, but they only appear in certain geometries. I suspect this is the cause (numerical accuracy that is not well distributed).

cschreib-ibex commented 1 year ago

Hi Ander. We did merge these changes in our fork: https://github.com/IbexInnovations/TIGRE/pull/3. I believe anyone can try it and see if it helps.