CERN / TIGRE

TIGRE: Tomographic Iterative GPU-based Reconstruction Toolbox
BSD 3-Clause "New" or "Revised" License
550 stars 182 forks source link

fix the DLL import issue on python 3.8 or higher on windows #387

Closed pjueon closed 2 years ago

pjueon commented 2 years ago

Related to #247 #349 Tested on python 3.9.2 & windows 10 / windows 11

AnderBiguri commented 2 years ago

Oh, fantastic! Super important update, I really appreciate it.

Let me test on my side, but I see no problem to merge.

pjueon commented 2 years ago

Wow, thanks for the incredibly fast response. Please note that I only tested on windows. It should work on linux too but I haven't tested yet.

AnderBiguri commented 2 years ago

Should not be a problem in Linux, as Linux doesn't use dlls. I will test nevertheless.

tsadakane commented 2 years ago

Great! Your PR fixes a problem on Python 3.10 that I reported in https://github.com/CERN/TIGRE/issues/375#issuecomment-1163136301 (I am sorry. Building TIGRE was OK and the error was at runtime.) Thank you very much.