search

CERN / TIGRE

TIGRE: Tomographic Iterative GPU-based Reconstruction Toolbox
BSD 3-Clause "New" or "Revised" License
535 stars 180 forks source link

Add arbitrary source and detector movement in common geometry, plus bug fixes #426

Closed yliu88au closed 1 year ago

yliu88au commented 1 year ago

Add a tool for arbitrary source and detector movement (specified by the centres of 3D coordinates) in common geometry, plus some bug fixes for large scale recons, should be able to handle very large voxel number recon problem if there is enough memory.

AnderBiguri commented 1 year ago

Thanks @yliu88au !

Just for me to get my head around:

You added more common geometries (super useful!)

You added tons and tons of typos and small bug fixes (thanks for the effort!)

what is the very large recon you added?

AnderBiguri commented 1 year ago

ohhh, I see <unsigned long>. I thought I had already solved all of theses, but apparently not....

yliu88au commented 1 year ago

You are welcome, Ander.

From: Biguri @.> Sent: Monday, 30 January 2023 9:16 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

ohhh, I see . I thought I had already solved all of theses, but apparently not....

— Reply to this email directly, view it on GitHubhttps://github.com/CERN/TIGRE/pull/426#issuecomment-1408340554, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR6OBUM2PVCZEULH7UMMY4LWU6IEVANCNFSM6AAAAAAUK5QCI4. You are receiving this because you were mentioned.Message ID: @.**@.>>

AnderBiguri commented 1 year ago

@yliu88au I updated master, but there were some strange merge conflicts on the new file (makes no sense, its a new file, I have no idea what was wrong).

If you have code that tests the new geometries you added, could you just make sure I did not resolve the conflicts wrong?

yliu88au commented 1 year ago

Hi Ander,

I do have test_plot_geometry.py file under ..\tests , I do not intend upload it yet, since this test relies on my version of plot_geometry.py to work, which is working under Anaconda python, but not bear-bone Python yet. So I will not update these two files until they are ready.

Hope this makes sense.

Regards, Yi

From: Biguri @.> Sent: Monday, 30 January 2023 10:12 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

@yliu88auhttps://github.com/yliu88au I updated master, but there were some strange merge conflicts on the new file (makes no sense, its a new file, I have no idea what was wrong).

If you have code that tests the new geometries you added, could you just make sure I did not resolve the conflicts wrong?

— Reply to this email directly, view it on GitHubhttps://github.com/CERN/TIGRE/pull/426#issuecomment-1408430958, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR6OBUIQTYQKQBTKPNWOSELWU6OXFANCNFSM6AAAAAAUK5QCI4. You are receiving this because you were mentioned.Message ID: @.***>

AnderBiguri commented 1 year ago

@yliu88au absolutely! I was not asking you to upload them, but instead if you could test the current TIGRE/master against them and let me know if there is a problem.

In order to merge them I needed to make some changes due to conflicts, and I am not 100% sure I made the correct changes....

yliu88au commented 1 year ago

It is very later in Australia now. I will try to test it tomorrow. 😉 Cheers

From: Biguri @.> Sent: Monday, 30 January 2023 10:29 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

@yliu88auhttps://github.com/yliu88au absolutely! I was not asking you to upload them, but instead if you could test the current TIGRE/master against them and let me know if there is a problem.

In order to merge them I needed to make some changes due to conflicts, and I am not 100% sure I made the correct changes....

— Reply to this email directly, view it on GitHubhttps://github.com/CERN/TIGRE/pull/426#issuecomment-1408457182, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR6OBUK47PNVT4V5CHCMHFLWU6QXPANCNFSM6AAAAAAUK5QCI4. You are receiving this because you were mentioned.Message ID: @.***>

AnderBiguri commented 1 year ago

Absolutely no hurry ;)

On Mon, 30 Jan 2023 at 11:40, yliu88au @.***> wrote:

It is very later in Australia now. I will try to test it tomorrow. 😉 Cheers

From: Biguri @.> Sent: Monday, 30 January 2023 10:29 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

@yliu88auhttps://github.com/yliu88au absolutely! I was not asking you to upload them, but instead if you could test the current TIGRE/master against them and let me know if there is a problem.

In order to merge them I needed to make some changes due to conflicts, and I am not 100% sure I made the correct changes....

— Reply to this email directly, view it on GitHub< https://github.com/CERN/TIGRE/pull/426#issuecomment-1408457182>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AR6OBUK47PNVT4V5CHCMHFLWU6QXPANCNFSM6AAAAAAUK5QCI4>.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/CERN/TIGRE/pull/426#issuecomment-1408472571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2OENFR64OKQNN3UDU4II3WU6SD5ANCNFSM6AAAAAAUK5QCI4 . You are receiving this because you modified the open/close state.Message ID: @.***>

yliu88au commented 1 year ago

Hi Ander,

My colleague and I have tested your newest merge today, so far we did not find any problem.

Cheers, Yi

From: Biguri @.> Sent: Monday, 30 January 2023 10:45 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

Absolutely no hurry ;)

On Mon, 30 Jan 2023 at 11:40, yliu88au @.***> wrote:

It is very later in Australia now. I will try to test it tomorrow. 😉 Cheers

From: Biguri @.> Sent: Monday, 30 January 2023 10:29 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

@yliu88auhttps://github.com/yliu88au absolutely! I was not asking you to upload them, but instead if you could test the current TIGRE/master against them and let me know if there is a problem.

In order to merge them I needed to make some changes due to conflicts, and I am not 100% sure I made the correct changes....

— Reply to this email directly, view it on GitHub< https://github.com/CERN/TIGRE/pull/426#issuecomment-1408457182>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AR6OBUK47PNVT4V5CHCMHFLWU6QXPANCNFSM6AAAAAAUK5QCI4>.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/CERN/TIGRE/pull/426#issuecomment-1408472571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2OENFR64OKQNN3UDU4II3WU6SD5ANCNFSM6AAAAAAUK5QCI4 . You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/CERN/TIGRE/pull/426#issuecomment-1408477122, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AR6OBUJJFYYQCPG4IX6EIXLWU6STBANCNFSM6AAAAAAUK5QCI4. You are receiving this because you were mentioned.Message ID: @.***>

AnderBiguri commented 1 year ago

Fantastic! thanks for the test!

On Tue, 31 Jan 2023 at 07:15, yliu88au @.***> wrote:

Hi Ander,

My colleague and I have tested your newest merge today, so far we did not find any problem.

Cheers, Yi

From: Biguri @.> Sent: Monday, 30 January 2023 10:45 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

Absolutely no hurry ;)

On Mon, 30 Jan 2023 at 11:40, yliu88au @.***> wrote:

It is very later in Australia now. I will try to test it tomorrow. 😉 Cheers

From: Biguri @.> Sent: Monday, 30 January 2023 10:29 PM To: CERN/TIGRE @.> Cc: Liu, Yi (Mineral Resources, Lucas Heights) @.>; Mention @.> Subject: Re: [CERN/TIGRE] Add arbitrary source and detector movement in common geometry, plus bug fixes (PR #426)

@yliu88auhttps://github.com/yliu88au absolutely! I was not asking you to upload them, but instead if you could test the current TIGRE/master against them and let me know if there is a problem.

In order to merge them I needed to make some changes due to conflicts, and I am not 100% sure I made the correct changes....

— Reply to this email directly, view it on GitHub< https://github.com/CERN/TIGRE/pull/426#issuecomment-1408457182>, or unsubscribe<

https://github.com/notifications/unsubscribe-auth/AR6OBUK47PNVT4V5CHCMHFLWU6QXPANCNFSM6AAAAAAUK5QCI4>.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/CERN/TIGRE/pull/426#issuecomment-1408472571, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC2OENFR64OKQNN3UDU4II3WU6SD5ANCNFSM6AAAAAAUK5QCI4>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub< https://github.com/CERN/TIGRE/pull/426#issuecomment-1408477122>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AR6OBUJJFYYQCPG4IX6EIXLWU6STBANCNFSM6AAAAAAUK5QCI4>.

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/CERN/TIGRE/pull/426#issuecomment-1409879637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2OENGT6IYBWUNDYIFQJ23WVC3YXANCNFSM6AAAAAAUK5QCI4 . You are receiving this because you modified the open/close state.Message ID: @.***>