elsevier_package.py: fix bug in calculation of number of pages

[fschwenn]

• Replaces lastpage - firstpage by lastpage - firstpage + 1

Signed-off-by: fschwenn florian.schwennsen@desy.de

[jalavik]

Thanks @fschwenn

Can you update the patch to:

• add a test in tests/elsevier_package_tests.py for this calculation to avoid a similar mistake (in case of refactoring)
• amend the sample output record to comply with this change tests/data/sample_consyn_output.xml (e.g. setting the correct page number)

[fschwenn]

Hi Jan,

isnt it enough to correct tests/data/sample_consyn_output.xml ? test_get_record(self) will check it, right?

Cheers, Florian

Florian Schwennsen Deutsches Elektronen-Synchrotron DESY Building 01 Room O1.446 phone: +49-40-8998-6190

From: "Jan Åge Lavik" notifications@github.com To: "inspirehep/harvesting-kit" harvesting-kit@noreply.github.com Cc: "Florian Schwennsen" florian.schwennsen@desy.de Sent: Monday, 23 March, 2015 15:44:25 Subject: Re: [harvesting-kit] elsevier_package.py: fix bug in calculation of number of pages (#130)

Thanks @fschwenn

Can you update the tests/elsevier_package_tests.py to:

• Add a test for this calculation to avoid a similar mistake (in case of refactoring)
• Amend the sample output record to comply with this change tests/data/sample_consyn_output.xml (e.g. setting the correct page number)

— Reply to this email directly or view it on GitHub .

[jalavik]

Hi @fschwenn. Indeed that is enough.

PS: You can update your pull request with git push -f (for --force) to the same branch (e.g. elsepagenum) instead of closing and opening a new one.

[fschwenn]

• Replaces lastpage - firstpage by lastpage - firstpage + 1
• Correct tests/data/sample_consyn_output.xml accordingly.

Signed-off-by: fschwenn florian.schwennsen@desy.de

[coveralls]

Coverage remained the same at 65.05% when pulling 1527040a876c00f3ac32782fd8756511b056ab30 on fschwenn:elsepagenum into 5120481a0bf353179b3de7129df003910369ff6c on inspirehep:master.

[jalavik]

@fschwenn Thanks!