search

CERNDocumentServer / harvesting-kit

A kit containing various utilities and scripts related to content harvesting used in Invenio Software (http://invenio-software.org) instances such as INSPIRE (http://inspirehep.net) and SCOAP3 (http://scoap3.org)
GNU General Public License v2.0
7 stars 18 forks source link

inspire_cds_package: update journal mappings #165

Closed michamos closed 7 years ago

michamos commented 7 years ago

Signed-off-by: Micha Moskovic michamos@gmail.com

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 67.549% when pulling c1cadf087ccedcd82c514e55fdf0724ae1840f46 on michamos:new-journal-mappings into d822d999d14ac5630e8df5a26e37bc1288935dc5 on inspirehep:master.

michamos commented 7 years ago

@kaplun I cannot assign you but would like a review.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 67.527% when pulling e0a056dafa09a9c7945da4e881df3f74ce75d064 on michamos:new-journal-mappings into d822d999d14ac5630e8df5a26e37bc1288935dc5 on inspirehep:master.

kaplun commented 7 years ago

BTW you are now admin of this repo too :dancer:

michamos commented 7 years ago

I repushed with readable CSV, pkg_resources use and your patch.

kaplun commented 7 years ago

cc: @switowski

kaplun commented 7 years ago

LGTM, beside the test currently failing...

michamos commented 7 years ago

@kaplun the test is failing because your patch makes the conversion correct for journals (no substring search), but breaks it for experiments (where substring search is needed because the experiment names are not spelled out fully in the mappings).

kaplun commented 7 years ago

OK. I will send a patch to my patch to add a flag to turn the feature on and off :dancer:

michamos commented 7 years ago

@kaplun did you ever merge your PR fixing the tests?

kaplun commented 7 years ago

Ahem...

kaplun commented 7 years ago

Looks like I did it in: f60664e643c0ade243f0141c22aeae4e84642fa2

kaplun commented 7 years ago

Closed in #166