elsevier_package: take articleID if journal does not use pagination

CERNDocumentServer / harvesting-kit

A kit containing various utilities and scripts related to content harvesting used in Invenio Software (http://invenio-software.org) instances such as INSPIRE (http://inspirehep.net) and SCOAP3 (http://scoap3.org)

GNU General Public License v2.0

7 stars 18 forks source link

elsevier_package: take articleID if journal does not use pagination #175

Closed fschwenn closed 4 years ago

fschwenn commented 4 years ago

If no first_page is found the code now looks for an articleID.

Signed-off-by: fschwenn florian.schwennsen@desy.de

coveralls commented 4 years ago

Coverage decreased (-0.006%) to 67.673% when pulling 4d895d4a99a10b6a5b86858bb401dc864302f558 on fschwenn:elseartid into 8c511810f4d7ec170a28bbd21f970d077da892d1 on inspirehep:master.

tsgit commented 4 years ago

This is nearly impossible to review, since there is no test case, desired output, or example. I wonder, when first_page is set to articleID this will also show up in 773__c as a page number. Is that desired? Presumably last_page is None or empty string in these circumstances. Is there any value in making a distinction between first_page and articleID by introducing a new variable instead of repurposing first_page?

fschwenn commented 4 years ago

legacy data model uses 773__c for page range as well as for articleIDs (see JHEP e.g.). If you need test suite - I can do it may be next week.