search

CERNStudyGroup / cernstudygroup.github.io

https://cernstudygroup.github.io
Other
20 stars 9 forks source link

Broken links in template #7

Closed betatim closed 8 years ago

betatim commented 8 years ago

Not sure what causes this but links in the "Howto be notified" section are broken http://cernstudygroup.github.io/%7B%7B%20site.github.repository_url%20%7D%7D. Seems like the template isn't being replaced by the actual URL?

adavidzh commented 8 years ago

The template driving this is https://github.com/CERNStudyGroup/cernstudygroup.github.io/blob/master/_data/en.yml#L26

I poked around and the only thing I found was that this seems to be an automatic variable: https://github.com/jekyll/jekyll-help/issues/5#issuecomment-39033862.

The {{ site.github.repository_url }} seems to not be properly interpreted. Could this be a bug upstream?

betatim commented 8 years ago

Seems so fundamental that I also guess it is upstream, but then https://github.com/UofTCoders/studyGroup seems to work fine :-/

adavidzh commented 8 years ago

UofTCoders does not have a _data/en.yml. Do you know where is their link coming from? (Github search is really bad: searching for repository in our repo yields zero results.)

betatim commented 8 years ago

Upstream discussion in mozillascience/studyGroup#47

RaoOfPhysics commented 8 years ago

Should we update our website locally?

betatim commented 8 years ago

We should ping @ibab to bump mozillascience/studyGroup#48 so that it gets merged upstream.

RaoOfPhysics commented 8 years ago

I pinged Abby on that PR.

RaoOfPhysics commented 8 years ago

Looks like https://github.com/mozillascience/studyGroup/pull/48 is resolved. Can someone with better Jekyll skillz pull the changes in to our repo?

RaoOfPhysics commented 8 years ago

Closed by #23.