CERT-Polska / karton-archive-extractor

Extractor of various archive formats for Karton framework
https://github.com/CERT-Polska/karton
GNU General Public License v3.0
5 stars 6 forks source link

sflock2's office changes fix #24

Closed doomedraven closed 3 years ago

doomedraven commented 3 years ago

0.3.18 didn't pick correctly office fixes, had to release

doomedraven commented 3 years ago

btw don't merge it yet, im doing full review, as i spot that rar.py was expecting pass as bytes and the rest pass as string, im activating github actions for autotests, so i will be back once i finished review i hope today

doomedraven commented 3 years ago

ok its done now, i have also fully remove six requirement so we can remove it from requirements as i don't see that you use it

doomedraven commented 3 years ago

there now tests to ensure that nothing is broken https://github.com/doomedraven/sflock/runs/3087298856

doomedraven commented 3 years ago

so for extractors it should be more than stable now, as you didn't pick the office i just change it to latest version, but changes in .22 and .23 is more for file recon fixes than archives

nazywam commented 3 years ago

Thanks!