CERT-Polska / karton

Distributed malware processing framework based on Python, Redis and S3.
https://karton-core.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
381 stars 45 forks source link

[v5] Revisited configuration - include args parser in configuration settings #176

Closed psrok1 closed 2 years ago

psrok1 commented 2 years ago

This PR addresses #121 and unlocks #124.

I have revisited configuration part and this PR is result of my analysis:

This PR breaks compatibility so version is bumped to v5.0.0. It shouldn't be a huge issue for most services, because Config override was pretty rare in Karton consumers.

I think it still needs to be redesigned

Closes #121

psrok1 commented 2 years ago

Ok, decided to leave Config object but configuration is kept in regular dict instead of ConfigParser instance. I also added some ConfigParser-like methods to get values using the same interface as in ConfigParser.