CERT-Polska / karton

Distributed malware processing framework based on Python, Redis and S3.
https://karton-core.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
381 stars 45 forks source link

Make task that stuck on STARTED state to be CRASHED after timeout #250

Open rakovskij-stanislav opened 5 months ago

rakovskij-stanislav commented 5 months ago

Current logic of karton-system deletes stuck STARTED tasks after timeout

https://github.com/CERT-Polska/karton/blob/81d0bb9203af87e159ab0572214c0ded1d27ff86/karton/system/system.py#L118

I suggest not to delete these tasks but make them CRASHED. It seems more reasonable 'cuz it's usual need to preserve these tasks instead of deleting them.