CERT-Polska / mquery

YARA malware query accelerator (web frontend)
GNU Affero General Public License v3.0
413 stars 77 forks source link

Refactor 2: make callers responsible for sessions #390

Closed msm-cert closed 1 month ago

msm-cert commented 5 months ago

Your checklist for this pull request

Second round of refactoring - move session management out of the database object (to make atomicity easier).

Beware of the dragons, this code has a long history of concurrency bugs. In the previous version, there was an implicit commit all the time... I'm not sure there are no places where i should call .commit() directly, but so far it works in my tests.

msm-cert commented 1 month ago

Refactoring can wait for another day. Currently I have no plans of merging this.