search

CESNET / Nemea-Framework

Nemea framework is the heart of the Nemea system. It contains implementation of common communication interfaces, UniRec data format and useful datastructures and algorithms.
11 stars 24 forks source link

Pytrap bugfixes #135

Closed cejkato2 closed 5 years ago

cejkato2 commented 5 years ago

Pytrap UnirecTemplate.getData() now returns only memory that was set (instead of the whole allocated memory). This saves resources when the data are sent via output IFC.

Additionally, check for argument of createMessage() was insufficient. The argument was changed to int in PyArg_ParseTupleAndKeywords() so the comparison with max size of UniRec message can work.

codecov-io commented 5 years ago

Codecov Report

Merging #135 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   51.48%   51.57%   +0.08%     
==========================================
  Files          51       51              
  Lines       10795    10794       -1     
==========================================
+ Hits         5558     5567       +9     
+ Misses       5237     5227      -10
Impacted Files Coverage Δ
pytrap/src/unirecmodule.c 69.47% <100%> (+0.24%) :arrow_up:
libtrap/src/trap.c 48.53% <0%> (+0.28%) :arrow_up:
libtrap/src/ifc_tcpip.c 57.44% <0%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 246b536...9510439. Read the comment docs.