search

CESNET / Nemea-Framework

Nemea framework is the heart of the Nemea system. It contains implementation of common communication interfaces, UniRec data format and useful datastructures and algorithms.
11 stars 24 forks source link

libtrap - bugfix in test_echo_reply #139

Closed barnama1 closed 4 years ago

barnama1 commented 4 years ago

trap_recv() may return other codes than 'terminated' that signify failure (e.g. unsuccessful certificate verification results in 'bad params').

codecov-io commented 4 years ago

Codecov Report

Merging #139 into master will increase coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   51.71%   51.88%   +0.17%     
==========================================
  Files          51       51              
  Lines       10634    10633       -1     
==========================================
+ Hits         5499     5517      +18     
+ Misses       5135     5116      -19
Impacted Files Coverage Δ
libtrap/tests/test_echo_reply.c 82.69% <ø> (+7.22%) :arrow_up:
libtrap/src/ifc_tcpip.c 59.35% <0%> (+1.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb41f5a...6550cb8. Read the comment docs.

cejkato2 commented 4 years ago

Thank your for the changes!