search

CESNET / Nemea-Framework

Nemea framework is the heart of the Nemea system. It contains implementation of common communication interfaces, UniRec data format and useful datastructures and algorithms.
11 stars 24 forks source link

Libtrap blocked module fix #155

Closed havraji6 closed 4 years ago

havraji6 commented 4 years ago

Fixed bug where one slow reading / idle client could block the entire module. This could happen with WAIT, HALF_WAIT or NO_WAIT timeouts.

Bug scenario:

flow source -> traffic_repeater -> flow_counter1
            -> flow_counter2

When we stop the flow_counter1 module and traffic_repeater is still running, flow_counter2 would not be able to receive any data from flow source.

codecov-io commented 4 years ago

Codecov Report

Merging #155 into master will increase coverage by 0.03%. The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   41.97%   42.01%   +0.03%     
==========================================
  Files          73       73              
  Lines       14750    14761      +11     
==========================================
+ Hits         6192     6202      +10     
- Misses       8558     8559       +1
Impacted Files Coverage Δ
libtrap/src/ifc_tcpip.c 57.20% <0.00%> (-0.62%) :arrow_down:
libtrap/src/third-party/libjansson/error.c 0.00% <0.00%> (ø)
libtrap/src/ifc_file.c 48.96% <14.28%> (-0.26%) :arrow_down:
libtrap/src/ifc_tls.c 57.84% <0.00%> (+1.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0c72b7...fb4da0c. Read the comment docs.