CESNET / Nemea-Framework

Nemea framework is the heart of the Nemea system. It contains implementation of common communication interfaces, UniRec data format and useful datastructures and algorithms.

11 stars 24 forks source link

treewide: prefer Python3 instead of Python #161

Closed BKPepe closed 3 years ago

BKPepe commented 3 years ago

When I compiled it successfully on Ubuntu 20.04 LTS, there was the following advise:

For installation of Python components run the following commands as root:
(cd pytrap; python setup.py install --record=installed-files.txt;)
(cd pycommon; python setup.py install --record=installed-files.txt;)

This ends up in my case that I don't have installed setuptools, but it was trying to install for Python2. When I used python3 setup.py, it works. Let's force users to use python3.

Ubuntu provides package python-is-python2 by default. User can choose if he wants to have this or python-is-python3. If you don't have symlink for python, it is better to use python3. On the other hand, Arch Linux symlinks python to python3. On Gentoo, the choise is up user. Commonly python should be linked to python3 in some way.

More details are in PEP 394. Since, there is removed python2 support for pytrap and pycommon and in shebangs you are using Python3, there should be python3 and in spec file there is explicit dependency on Python3 packages.

python should be used if it is possible to use Python2 or Python3.

codecov-io commented 3 years ago

Codecov Report

Merging #161 (75584ff) into master (9facfe7) will increase coverage by 0.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   41.95%   42.05%   +0.09%     
==========================================
  Files          73       73              
  Lines       14766    14767       +1     
==========================================
+ Hits         6195     6210      +15     
+ Misses       8571     8557      -14

Impacted Files	Coverage Δ
libtrap/src/trap.c	`44.90% <0.00%> (-0.03%)`	:arrow_down:
libtrap/src/ifc_tcpip.c	`59.22% <0.00%> (+1.75%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9facfe7...75584ff. Read the comment docs.

cejkato2 commented 3 years ago

I totally agree.